gh-135410: Use a critical section around StringIO.__next__#135412
Merged
kumaraditya303 merged 3 commits intopython:mainfrom Jun 12, 2025
Merged
gh-135410: Use a critical section around StringIO.__next__#135412kumaraditya303 merged 3 commits intopython:mainfrom
StringIO.__next__#135412kumaraditya303 merged 3 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm generally not a fan of adding locks around
__next__, because concurrent iteration isn't generally a real use case, butreadlinescalls into__next__.StringIOmethods in threads on free-threading debug build #135410